Skip to content

Conversation

estebank
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2022

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 29, 2022
Copy link
Contributor

@eholk eholk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

@estebank
Copy link
Contributor Author

@bors r=eholk

@bors
Copy link
Collaborator

bors commented Dec 30, 2022

📌 Commit b9439eb has been approved by eholk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 30, 2022
@Xiretza
Copy link
Contributor

Xiretza commented Dec 30, 2022

This could've benefited from a split into two commits: one to update the variable interpolations in format!() calls (no functional change), and another to change the actual diagnostic verbosity and update tests. Probably not a big enough issue to still do it now though.

jyn514 added a commit to jyn514/rust that referenced this pull request Dec 30, 2022
…=eholk

Use verbose suggestions for mutability errors
@bors
Copy link
Collaborator

bors commented Dec 31, 2022

⌛ Testing commit b9439eb with merge e060a2386699edf9a12c4c392c96fa113a49a8db...

@jyn514
Copy link
Member

jyn514 commented Dec 31, 2022

@bors r- r+ tree closed in #106232 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 31, 2022
@bors
Copy link
Collaborator

bors commented Dec 31, 2022

📌 Commit b9439eb has been approved by jyn514

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

🌲 The tree is currently closed for pull requests below priority 500. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2022
@compiler-errors

This comment was marked as resolved.

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Checking which error codes lack tests...
Found 507 error codes
Found 0 error(s) in error codes
Done!
thread '<unnamed>' panicked at 'Encountered error while testing Git status: "failed to execute git log command: fatal: ambiguous argument ':!src/tools/miri': unknown revision or path not in the working tree.\nUse '--' to separate paths from revisions, like this:\n'git <command> [<revision>...] -- [<file>...]'\n"', src/tools/tidy/src/no_merge.rs:23:25
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Any { .. }', src/tools/tidy/src/main.rs:42:61
* 393 features
Build completed unsuccessfully in 0:00:26

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

⌛ Testing commit b9439eb with merge 96c1f33...

@bors
Copy link
Collaborator

bors commented Dec 31, 2022

☀️ Test successful - checks-actions
Approved by: jyn514
Pushing 96c1f33 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 31, 2022
@bors bors merged commit 96c1f33 into rust-lang:master Dec 31, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (96c1f33): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [1.1%, 1.6%] 3
Improvements ✅
(primary)
-2.6% [-2.7%, -2.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.6% [-2.7%, -2.6%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…yn514

Use verbose suggestions for mutability errors
@estebank estebank deleted the mutability-suggestions branch November 9, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants